-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to v2.7.0 #3
Conversation
just a typo in the docs and in the public_subnet_tags in the simple example
…aws-modules#155) * Provide separate route tables for db/elasticache/redshift * Added example for saperate routes * Updated PR with suggestions * Make redshift to use separate subnet route table also * More cleanup and updates * Fixed one more spelling mistake
* Added support for IPv6 to VPC
* Add secondary CIDR block support using a local variable to derive the vpc id to ensure the CIDR block operations are applied before the CIDR operations * Add secondary cidr block outputs to module output * Add the wonderful examples from matthiasr's PR located at terraform-aws-modules#162 all credit goes to them for this wonderful example * From copy and paste accidentally used variable name that differed from these variables * Resolve typo in secondary_cidr_blocks * Fixed README formatting * Followups for terraform-aws-modules#161 * Added local.vpc_id with description
…es#168) * add vars for custom subnet and route table names * revert db suffix to "db"
* Added amazon_side_asn to vpn_gateway * change to Amazon default ASN (as per API) (terraform-aws-modules#176) https://docs.aws.amazon.com/cli/latest/reference/ec2/create-vpn-gateway.html
…y lowercase alphanumeric characters and hyphens allowed in name Read more: terraform-aws-modules#180
…-name-issue Fix for the error: module.vpc.aws_redshift_subnet_group.redshift: onl…
…es/feature-db-igw-public-access Added IGW route for DB subnets (based on terraform-aws-modules#179)
…es/elasticache_subnet_group Added possibility to control creation of elasticache and redshift subnet groups
…es/ssm_and_ec2_vpc_endpoints Added SSM and EC2 VPC endpoints
…ase-route-to-natgw adding option to create a route to nat gateway in database subnets
* add ecs vpc endpoints * add ecs vpcendpoints outputs * add ecs vpc endpoints to readme inputs/outputs table * add ecs vpc endpoints to readme endpoint list
* run terraform 0.12upgrade * Cleanup for Terraform 0.12 (closes terraform-aws-modules#265, terraform-aws-modules#228)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
||
tags = { | ||
Owner = "user" | ||
Environment = "test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this for test purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is coming from upstream, seems it's for documentation purpose. nice catch tough
fetched from upstream v.2.7.0 tag to get terraform 0.12 support, afterward changed the vpc name from
this
tomod
because this name change requires vpc to be recreated which can cause downtime.